-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.19 #4932
Merged
Update to 1.19 #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
added
type: enhancement
Features and feature requests.
module: main
Issues or PRs for the main Essentials module
labels
Jun 7, 2022
WHOEVER MERGES THIS PLEASE USE REBASE AND MERGE |
sando1234
suggested changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found nothing wrong :D.
mdcfe
force-pushed
the
mc/1.19
branch
2 times, most recently
from
June 15, 2022 14:29
34b8610
to
95119b1
Compare
mdcfe
requested changes
Jun 15, 2022
Note: this action was performed by a human (@mdcfe) under the Flask-Bot account.
`commons-lang3` is scheduled for removal by Spigot. This commit reimplements the methods we use from StringUtils in StringUtil, and replaces NumberUtils.isDigits(String) with NumberUtil.isLong(String).
mdcfe
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: main
Issues or PRs for the main Essentials module
type: enhancement
Features and feature requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the new chat stuff, I'll tackle that once we do adventure support (#4717) in 2.20 or I may use something md_5 hacks into his api if its easy enough
thanks for your concern @broccolai