Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added permission node for Nickname Prefix bypass #4995

Merged
merged 7 commits into from
Oct 25, 2022
Merged

Added permission node for Nickname Prefix bypass #4995

merged 7 commits into from
Oct 25, 2022

Conversation

Baylem
Copy link
Contributor

@Baylem Baylem commented Jul 15, 2022

Information

This PR closes #4994.

Details

Proposed feature:

Allow a permission to determine whether the nickname prefix gets applied to a group or user. It also removes a statement that is not true in the essentials config, the nickname prefix is NOT included in the nickname max length.

Environments tested:

OS: Windows 11

Java version: 17.0.2

  • Most recent Paper version (1.19, git-Paper-61)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

Before change: https://i.imgur.com/HZaKazT.png
After change: https://i.imgur.com/QyitAPl.png

@pop4959 pop4959 added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels Aug 7, 2022
pop4959
pop4959 previously approved these changes Oct 15, 2022
View reviewed changes
mdcfe
mdcfe requested changes Oct 15, 2022
View reviewed changes
Copy link
Member

@mdcfe mdcfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think essentials.nick.prefix.hide is a bit clearer of a name for the permission. Otherwise, I like this feature and would be happy to merge it if you're happy with changing the permission name.

@Evidentsinger14
Copy link
Member

Thanks for the PR! I think essentials.nick.prefix.hide is a bit clearer of a name for the permission. Otherwise, I like this feature and would be happy to merge it if you're happy with changing the permission name.

I feel like essentials.nick.hideprefix would be better - there aren’t any other permissions that have follow .nick.prefix (that I’m aware of).

Baylem
Baylem commented Oct 21, 2022
View reviewed changes
Copy link
Contributor Author

@Baylem Baylem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the permission node with Evident's suggestion

@Baylem Baylem requested a review from mdcfe October 21, 2022 22:26
@Baylem @JRoy
Update Essentials/src/main/java/com/earth2me/essentials/User.java
0da7ab6 
Removing ternary/conditional for if/else statement to increase readability

Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
@mdcfe mdcfe merged commit 20011b9 into EssentialsX:2.x Oct 25, 2022
@Baylem Baylem deleted the nick-prefix-node branch April 16, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRoy JRoy JRoy left review comments

@mdcfe mdcfe mdcfe approved these changes

@pop4959 pop4959 pop4959 left review comments

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Baylem @Evidentsinger14 @mdcfe @JRoy @pop4959