-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Inventory Handling #5021
Conversation
TODO: I NEED TO ADD SPECIAL ARMOR SLOT PARSING TO Inventories#parseInventoryData because otherwise we dismiss slots too early for the space calculations :(
This makes sure armor is added to armor slots first during Inventories#addItem to ensure space is utilized as best as possible.
ready for review, needs testing with all commands/features that touch items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few notes on initial look-through
Essentials/src/main/java/com/earth2me/essentials/craftbukkit/Inventories.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/craftbukkit/Inventories.java
Outdated
Show resolved
Hide resolved
Tested commands: Didn't test keep inventory policy or trade/enchant signs yet. Looks good so far though, didn't find any issues with any commands. |
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java
Still haven't tested the things above, but assuming those are ok this PR looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of things to note.
there are a LOT of weird inventory stuff going on in EssX.
Fixes #3810
Fixes #4248
maybe more inventory issues that I'm unable to find?