Add spawnable boat variants #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop4959
added
type: enhancement
|
I made a slight mistake, the |
JRoy
requested changes
Aug 2, 2022
JRoy
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was quickly looking over the new mobs in 1.19 to make sure we didn't miss anything new, and noticed that boat variants are not covered currently in MobCompat. Apparently this has been the case since 1.9 (when boat variants were added).
Additionally, 1.19 introduces a new enum
Boat.Typeand deprecatesTreeSpecies. We will need to support both for backwards compatibility, but new variants (e.g. mangrove) are only supported using the new enum (in 1.19+). I added a newBoatVariantenum in MobCompat to map between the two (as we currently do forCatTypeandVillagerProfession).