Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with chat preview refactor #5062

Merged
merged 3 commits into from
Aug 14, 2022
Merged

Fix issues with chat preview refactor #5062

merged 3 commits into from
Aug 14, 2022

Conversation

mdcfe
Copy link
Member

@mdcfe mdcfe commented Aug 14, 2022

Information

  1. This PR fixes Sudo c: makes the player send their previewed message #5055.
  2. It also fixes a separate issue in which all local chat messages are sent globally.

Details

Proposed fix:

  1. AsyncPlayerChatEvents fired by a Player#chat call are expected to be on the main thread. Check for this before applying the format from the player's preview.
  2. Pass the radius from the IntermediateChat to the ProcessedChat when moving from one state to the other.

Environments tested:

OS: Windows 11 22H2

Java version: Eclipse Temurin 17.0.2

  • Most recent Paper version (1.19.2, git-Paper-129)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

@mdcfe mdcfe added this to the 2.20.0 milestone Aug 14, 2022
@mdcfe mdcfe added bug: confirmed Confirmed bugs in EssentialsX. module: chat Issues or PRs for the EssentialsChat module type: bugfix PRs that fix bugs in EssentialsX. labels Aug 14, 2022
@JRoy JRoy merged commit 2f4f555 into 2.x Aug 14, 2022
@JRoy JRoy deleted the fix/local-chat branch August 14, 2022 22:50
@mdcfe mdcfe modified the milestones: 2.20.0, 2.19.7 Aug 15, 2022
@SrBedrock SrBedrock mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRoy JRoy JRoy approved these changes

Assignees
No one assigned
Labels
bug: confirmed Confirmed bugs in EssentialsX. module: chat Issues or PRs for the EssentialsChat module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Milestone
2.19.7
Development

Successfully merging this pull request may close these issues.

Sudo c: makes the player send their previewed message
2 participants
@mdcfe @JRoy