Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup and Logger Fixes #5077

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Backup and Logger Fixes #5077

merged 2 commits into from
Aug 18, 2022

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Aug 18, 2022

rebase and merge

Fixes #4999

@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Aug 18, 2022
@JRoy JRoy added this to the 2.19.7 milestone Aug 18, 2022
@JRoy JRoy enabled auto-merge (rebase) August 18, 2022 17:41
@JRoy JRoy merged commit 0be056b into EssentialsX:2.x Aug 18, 2022
@JRoy JRoy deleted the fix/4999 branch August 18, 2022 23:51
@DuckDuckWhale
Copy link

Hmm, I wonder why return immediately when when the message is null? Wouldn't it be better to issue a warning in the log to help discover bugs like #4999?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when backup script is not executable
3 participants