-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutable "viewers" list to DiscordRelayEvent #5080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
requested changes
Aug 21, 2022
EssentialsDiscord/src/main/java/net/essentialsx/api/v2/events/discord/DiscordRelayEvent.java
Outdated
Show resolved
Hide resolved
EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/DiscordListener.java
Outdated
Show resolved
Hide resolved
JRoy
requested changes
Aug 22, 2022
EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/DiscordListener.java
Outdated
Show resolved
Hide resolved
EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/DiscordListener.java
Outdated
Show resolved
Hide resolved
EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/DiscordListener.java
Outdated
Show resolved
Hide resolved
EssentialsDiscord/src/main/java/net/essentialsx/api/v2/events/discord/DiscordRelayEvent.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
JRoy
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for 2.20
JRoy
added
type: enhancement
Features and feature requests.
module: discord
Issues or PRs for the EssentialsDiscord module
type: api
Issue/Pull Request regards user-facing API
and removed
type: enhancement
Features and feature requests.
labels
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: discord
Issues or PRs for the EssentialsDiscord module
type: api
Issue/Pull Request regards user-facing API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #5070.
Details
Proposed feature:
Expose a mutable list in the DiscordRelayEvent to change who receives the bridged message.
Environments tested:
OS: macOS
Java version: openjdk version "17.0.1" 2021-10-19
Demonstration: