Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutable "viewers" list to DiscordRelayEvent #5080

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

NoahvdAa
Copy link
Contributor

Information

This PR closes #5070.

Details

Proposed feature:

Expose a mutable list in the DiscordRelayEvent to change who receives the bridged message.

Environments tested:

OS: macOS

Java version: openjdk version "17.0.1" 2021-10-19

  • Most recent Paper version (1.19.2 git-Paper-132)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

@EventHandler
public void onDiscordRelay(DiscordRelayEvent event) {
    event.getViewers().removeIf(user -> user.getName().equals("Jroy"));
}

@JRoy JRoy added this to the 2.20.0 milestone Aug 21, 2022
@NoahvdAa NoahvdAa requested a review from JRoy August 22, 2022 00:34
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
@NoahvdAa NoahvdAa requested a review from JRoy August 22, 2022 01:04
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for 2.20

@JRoy JRoy added type: enhancement Features and feature requests. module: discord Issues or PRs for the EssentialsDiscord module type: api Issue/Pull Request regards user-facing API and removed type: enhancement Features and feature requests. labels Aug 23, 2022
@JRoy JRoy enabled auto-merge (squash) October 14, 2022 22:23
@JRoy JRoy added this to In progress in Discord module via automation Oct 14, 2022
@JRoy JRoy merged commit 4aa93a4 into EssentialsX:2.x Oct 14, 2022
Discord module automation moved this from In progress to Done Oct 14, 2022
@NoahvdAa NoahvdAa deleted the feat/relayevent-viewers branch October 15, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: discord Issues or PRs for the EssentialsDiscord module type: api Issue/Pull Request regards user-facing API
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants