Fix Essentials#getUser not caching newly created NPC users #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
added
type: bugfix
pop4959
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essntials#getUser originally calls UserMap#getUser to try and fetch a user from the cache (or get an actual CraftPlayer), and if that returns null, it will call UserMap#loadUncachedUser which will create a new User object but not load it into cache. Since Essentials#getUser calls UserMap#getUser which has the behavior of loading a User object into cache anyway, we need to emulate that behavior manually when it comes to NPC accounts otherwise we end up creating an NPC user object every time it's looked up (which could be when it teleports or its punched from JailListener)