Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first join message type for Discord #5160

Merged
merged 7 commits into from
Dec 24, 2022

Conversation

diademiemi
Copy link
Contributor

Information

This PR partially closes #5155

Details

Proposed feature:
Add a new message type for when a player has joined for the first time.

This adds a new type first-join with the default placeholder ":arrow_right: {displayname} has joined the server for the first time!".

Environments tested:

OS: Fedora 36

Java version: 17.0.5

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8
    Don't see how this could differ on other server versions.

Demonstration:
As an example here I have made it so that the first-join messages are sent to the staff channel. You would likely just want these in the primary channel though.

...
# To disable a message from showing, use 'none' as the channel name.
message-types:
  # Join messages sent when a player joins the Minecraft server.
  join: primary
  # Join messages sent when a player joins the Minecraft server for the first time.
  first-join: staff

...
  # This is the message sent to Discord when a player joins the minecraft server for the first time
  # The following placeholders can be used here:
  # - {username}: The name of the user joining
  # - {displayname}: The display name of the user joining
  # - {joinmessage}: The full default join message used in game
  # - {online}: The amount of players online
  # - {unique}: The amount of unique players to ever join the server
  # ... PlaceholderAPI placeholders are also supported here too!
  first-join: ":arrow_right:** {displayname} has joined the server for the first time!**"

image

@diademiemi diademiemi changed the title Add roles selection option Add first join message type for Discord Nov 16, 2022
@diademiemi
Copy link
Contributor Author

Updated title, GitHub had changed it back when I switched branches

Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few things otherwise good

diademiemi and others added 3 commits November 19, 2022 01:18
…dSettings.java

Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
@mdcfe mdcfe merged commit db10678 into EssentialsX:2.x Dec 24, 2022
@mdcfe
Copy link
Member

mdcfe commented Dec 24, 2022

Thanks for the contribution! Apologies for the delay in merging this.

@diademiemi
Copy link
Contributor Author

No worries! I've got a few other Discord PRs open, there was one I was going to change something about which I honestly forgot about up until now, I'll get to working on that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants