-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first join message type for Discord #5160
Conversation
Updated title, GitHub had changed it back when I switched branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few things otherwise good
EssentialsDiscord/src/main/java/net/essentialsx/discord/DiscordSettings.java
Outdated
Show resolved
Hide resolved
EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/BukkitListener.java
Outdated
Show resolved
Hide resolved
…dSettings.java Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
EssentialsDiscord/src/main/java/net/essentialsx/discord/listeners/BukkitListener.java
Outdated
Show resolved
Hide resolved
Thanks for the contribution! Apologies for the delay in merging this. |
No worries! I've got a few other Discord PRs open, there was one I was going to change something about which I honestly forgot about up until now, I'll get to working on that right now. |
Information
This PR partially closes #5155
Details
Proposed feature:
Add a new message type for when a player has joined for the first time.
This adds a new type
first-join
with the default placeholder":arrow_right: {displayname} has joined the server for the first time!"
.Environments tested:
OS: Fedora 36
Java version:
17.0.5
Don't see how this could differ on other server versions.
Demonstration:
As an example here I have made it so that the first-join messages are sent to the staff channel. You would likely just want these in the primary channel though.