Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strict comparison for potions in trade signs #5260

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Use strict comparison for potions in trade signs #5260

merged 2 commits into from
Apr 2, 2023

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Feb 28, 2023

Fixes #5242

@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Feb 28, 2023
@JRoy JRoy added this to the 2.20.0 milestone Feb 28, 2023
@JRoy JRoy enabled auto-merge (squash) April 2, 2023 21:43
@JRoy JRoy merged commit 0f4af9e into EssentialsX:2.x Apr 2, 2023
1 check passed
@JRoy JRoy deleted the fix/trade-potion-strict-compare branch April 2, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pop4959 pop4959 pop4959 approved these changes

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.

Trade signs - EXPLOIT (another...)
2 participants
@JRoy @pop4959