Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire SignChangeEvent in /editsign #5304

Merged
merged 8 commits into from
May 2, 2023
Merged

Fire SignChangeEvent in /editsign #5304

merged 8 commits into from
May 2, 2023

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Apr 10, 2023

No description provided.

@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Apr 10, 2023
@JRoy JRoy added this to the 2.20.0 milestone Apr 10, 2023
@JRoy JRoy mentioned this pull request Apr 10, 2023
Closed
3 tasks
pop4959
pop4959 previously approved these changes Apr 13, 2023
View reviewed changes
pop4959
pop4959 previously requested changes Apr 15, 2023
View reviewed changes
Copy link
Member

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid calling sign change event 4 times

@JRoy JRoy requested review from pop4959 and mdcfe April 15, 2023 01:13
@mdcfe mdcfe mentioned this pull request Apr 29, 2023
Merged
@JRoy JRoy requested a review from mdcfe May 1, 2023 23:14
@mdcfe mdcfe dismissed pop4959’s stale review May 2, 2023 19:50

Already addressed

@JRoy JRoy merged commit ee7ea2a into EssentialsX:2.x May 2, 2023
1 check passed
@JRoy JRoy deleted the fix/sign-change branch May 2, 2023 20:14
mdcfe pushed a commit that referenced this pull request May 8, 2023
@JRoy
Fix SignChangeEvent never actually being called (#5341)
1a4f639 
Fixes #5340. Caused by a regression in #5304 which reverted the behaviour introduced in #5304.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcfe mdcfe mdcfe approved these changes

@pop4959 pop4959 Awaiting requested review from pop4959

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JRoy @mdcfe @pop4959