Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to get recipe of item in hand #5346

Merged
merged 9 commits into from
May 28, 2023
Merged

Add ability to get recipe of item in hand #5346

merged 9 commits into from
May 28, 2023

Conversation

Evidentsinger14
Copy link
Member

@Evidentsinger14 Evidentsinger14 commented May 12, 2023 •
edited

Information

This PR closes #5259

Details

Proposed feature:

Environments tested:

OS: Windows 10

Java version: Java 17

  • Most recent Paper version (1.19.4, git-Paper-527)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

image
image
image

@pop4959 pop4959 added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels May 27, 2023
pop4959
pop4959 previously approved these changes May 27, 2023
View reviewed changes
@Evidentsinger14 @JRoy
Update Essentials/src/main/java/com/earth2me/essentials/commands/Comm…
640ed24 
…andrecipe.java

Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
JRoy
JRoy reviewed May 27, 2023
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

JRoy
JRoy previously approved these changes May 27, 2023
View reviewed changes
pop4959
pop4959 previously approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double approval

@JRoy JRoy dismissed stale reviews from pop4959 and themself via 9ee9ffc May 28, 2023 18:24
@JRoy JRoy changed the title add hand argument to /recipe to get recipe of item in main hand. Add ability to get recipe of item in hand May 28, 2023
@JRoy JRoy enabled auto-merge (squash) May 28, 2023 18:25
@JRoy JRoy merged commit 646b60a into EssentialsX:2.x May 28, 2023
1 check passed
@Evidentsinger14 Evidentsinger14 deleted the impl/recipe_hand branch May 28, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRoy JRoy JRoy approved these changes

@pop4959 pop4959 pop4959 left review comments

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/recipe hand -> get recipe for an item in hand
3 participants
@Evidentsinger14 @JRoy @pop4959