Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run AntiBuild checks on NPCs #5365

Merged
merged 2 commits into from
May 27, 2023
Merged

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented May 27, 2023

Citizens pathfinding can trigger these events(!) and then cause LuckPerms to attempt an offline lookup which now raises an exception at runtime. DaFeels.

Fixes #5361

Citizens pathfinding can trigger these events(!) and then cause
LuckPerms to attempt an offline lookup which now raises an
exception at runtime. DaFeels.
@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: antibuild Issues or PRs for the EssentialsAntiBuild module labels May 27, 2023
@JRoy JRoy added this to the 2.20.1 milestone May 27, 2023
Copy link
Member

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More NPC checks never hurt I guess

@JRoy JRoy merged commit a4fb02f into EssentialsX:2.x May 27, 2023
1 check passed
@JRoy JRoy deleted the fix/npc-anti-build branch May 27, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: antibuild Issues or PRs for the EssentialsAntiBuild module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlayerInteractEvent Error
2 participants