Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to append an event with wrong id results in UnknownError #344

Open
Imanghvs opened this issue Oct 21, 2023 · 1 comment
Open

Trying to append an event with wrong id results in UnknownError #344

Imanghvs opened this issue Oct 21, 2023 · 1 comment
Assignees
Labels
kind/enhancement Issues which are a new feature

Comments

@Imanghvs
Copy link
Contributor

After calling appendToStream method with an id which is not a uuid, I get this error:

UnknownError: Could not recognize BadRequest

I was in situations where it took a long until I realized I was passing a wrong id through my app. I suggest having a validator on input, so we don't send such requests to EventStore at all (instead we can throw something like InvalidIdException.

I really like to make a PR for id validation, along with related tests if everyone agrees on such a fix.

@w1am w1am added the kind/enhancement Issues which are a new feature label Oct 23, 2023
@cdevarenne
Copy link
Contributor

Hi @Imanghvs thank you for reporting this issue and agree with you to provide a better error. Please go ahead and submit a fix and we'll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues which are a new feature
Projects
None yet
3 participants