Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-nuxt to hardcore/vue #588

Open
EvgenyOrekhov opened this issue Aug 1, 2022 · 6 comments
Open

Add eslint-plugin-nuxt to hardcore/vue #588

EvgenyOrekhov opened this issue Aug 1, 2022 · 6 comments

Comments

@EvgenyOrekhov
Copy link
Owner

EvgenyOrekhov commented Aug 1, 2022

https://github.com/nuxt/eslint-plugin-nuxt

Note: eslint-plugin-nuxt hasn't had any updates for months, may be abandoned.

@EvgenyOrekhov
Copy link
Owner Author

@alexkramer98 Pinging you for visibility. PRs are welcome!

@alexkramer98
Copy link
Contributor

Maybe we could take a look at adding https://github.com/nuxt/eslint-config instead.

There has not yet been a response from a team member here: nuxt/eslint-plugin-nuxt#173,
but it looks more complete and active. It is however still under heavy development.

https://github.com/nuxt/eslint-config also solves some issues I've had to fix for #681. These redundant fixes can then be removed from eslint-config-hardcore. It also adds some more tweaks I did not think of before.

I do think this might lead to needing to have seperate a config for Nuxt. This could of course extend the existing hardcore/vue config.

@EvgenyOrekhov
Copy link
Owner Author

We can't use nuxt/eslint-config because it extends eslint:recommended and @typescript-eslint/eslint-recommended, which would override rules from hardcore and hardcore/ts. But we could copy tweaks from nuxt/eslint-config to hardcore/vue.

I would prefer to have a single hardcore/vue config, but if there are significant differences between Vue.js and Nuxt, we could consider creating hardcore/nuxt config. I think I would prefer it to be an additional config (that doesn't extend hardcore/vue), so for a Nuxt project you would need to use "extends": ["hardcore", "hardcore/ts", "hardcore/vue", "hardcore/nuxt"].

@alexkramer98
Copy link
Contributor

@EvgenyOrekhov You're right. I overlooked that one. I will try to take a look at this (and #589) in the coming weeks.

@EvgenyOrekhov
Copy link
Owner Author

Note: eslint-plugin-nuxt hasn't had any updates for months, may be abandoned.

@alexkramer98
Copy link
Contributor

eslint-plugin-nuxt still hasn't had any updates. It might be a better idea to copy some tweaks from https://github.com/nuxt/eslint-config. I will take a look at that this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants