Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respmod support #17

Open
irrenhaus opened this issue Jul 20, 2014 · 4 comments
Open

respmod support #17

irrenhaus opened this issue Jul 20, 2014 · 4 comments

Comments

@irrenhaus
Copy link

Hey,

just wanted to ask if you guys have any plans to implement ICAP respmod support?

Keep up the great work with ExaProxy :)

@thomas-mangin
Copy link
Member

Hello Nils,

Sorry, no, we have no immediate plan to do it, as :

  • we have no need for the feature ourselves
  • we are not parsing the reply but are simply proxying it
  • have many more feature we would like to add first (monitoring, perhaps HTTP/2 support, ...)

But it may get added if enough people let us know what we should stop being lazy and selfish 😸

@irrenhaus
Copy link
Author

Hello Thomas,

thanks for the answer! I absolutely can understand that :)

Let's assume for a moment that I would like to have this feature and would like to contribute this to Exaproxy.
What do you think, what would be a good point to start with an implementation for this? Would it be the correct way to change the code for 'read_download' events in reactor.py and send them through a newly written part (which does the ICAP respmod stuff) from there?

Best

@thomas-mangin
Copy link
Member

Nils, I would say that you should take some time to understand the reactor and then, yes, it would be the way to go.

@irrenhaus
Copy link
Author

Perfect, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants