Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-07-25 #10077

Closed
92 tasks done
OSBotify opened this issue Jul 25, 2022 · 33 comments
Closed
92 tasks done

Deploy Checklist: New Expensify 2022-07-25 #10077

OSBotify opened this issue Jul 25, 2022 · 33 comments
Assignees
@applausebot
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jul 25, 2022 •
edited by yuwenmemon

Release Version: 1.1.86-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@luacmartins luacmartins self-assigned this Jul 25, 2022
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jul 25, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.86-0 🚀

@jasperhuangg
Copy link
Contributor

I believe #10079 is related to a PR that I merged recently. I'm OOO today but will be able to take a look at this first thing tomorrow. Can we take this off the deploy checklist?

@luacmartins
Copy link
Contributor

@jasperhuangg not sure on what you mean by "take this off the deploy checklist". This seems like a blocker to me. We should either revert the offending PR or find a fix in time for the deploy.

@jasperhuangg
Copy link
Contributor

@jasperhuangg not sure on what you mean by "take this off the deploy checklist". This seems like a blocker to me. We should either revert the offending PR or find a fix in time for the deploy.

@luacmartins sorry, that's actually exactly what I meant! Let's go ahead and revert it, I'll take a look into a fix tomorrow.

@luacmartins
Copy link
Contributor

Sure, wanna put up a revert? I can review it.

@marcaaron
Copy link
Contributor

Reverting #9294 because it is causing the issue here #10085

@marcaaron
Copy link
Contributor

#10094 seems related to removing the getBetas() call

@marcaaron
Copy link
Contributor

This one #10088 seems related to the same PR we are talking about reverting above (this one). Auto-revert option didn't work so it will need to be reverted and conflicts fixed.

@luacmartins
Copy link
Contributor

Thanks for the help @marcaaron!

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.86-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-1 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.86-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-2 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.86-4 🚀

@mvtglobally
Copy link

@luacmartins Regression is completed
PR #9294 Is failing due to #10107. Not a blocker checking off
PR #9423 is failing due to #10083. We will retest on the newest build
PR #9589 (comment) - Internal QA
PR #9613 Is failing with KI. Checking off
PR #9677 is failing due to #10106
PR #9769 is failing due to #9769 (comment)
PR #9800 is failing due to #10079 & #10108 . We will retest and check off
PR #9834
PR #9895 is failing due to #10087. Since blocker is removed, Can I check off?
PR #9906 failing #10104. not a blocker. checking off
PR #9943 is blocked by #10084
PR #10023 was failing due to #10079. Will retest and confirm
and Checking CPs.

Will send updated summary in a bit

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-4 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.86-5 🚀

@luacmartins
Copy link
Contributor

I removed the blocker label from the issues below:

@luacmartins
Copy link
Contributor

@mvtglobally

PR #9895 is failing due to #10087. Since blocker is removed, Can I check off?

Yes, we can check this off. The PR was reverted.

PR #9943 is blocked by #10084

I think this should be productionQA now

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-5 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

luacmartins commented Jul 27, 2022 •
edited

@mvtglobally could you please send another QA summary please?

@mvtglobally
Copy link

sure, Will share summary in a bit.

@mvtglobally
Copy link

mvtglobally commented Jul 28, 2022 •
edited

@luacmartins
PR #9423 Retested on the newest build. Checking off
PR #9589 (comment) - Internal QA
PR #9677 Retested. Issue is still failing. Do we need to wait for push https://github.com/Expensify/Web-Expensify/pull/34424?
PR #9769 is failing due to #9769 (comment) - Any feedback if we can check it off? We are unable to verify.
PR #9800 Re-tested - Checking off
#9834 checking off
PR #9895 Checking off since its no longer a blocker
PR #9943 #10084 (comment) Checking off
PR #10023 retested - Checking off
PR #10092 Android was failing due to #10083. We are double checking now
and checking #10136 which just got added

We are also re-testing 3 Blockers as per your steps

@luacmartins
Copy link
Contributor

luacmartins commented Jul 28, 2022 •
edited

@mvtglobally

PR #9677 Retested. Issue is still failing. Do we need to wait for push https://github.com/Expensify/Web-Expensify/pull/34424?

I don't think we should wait for this, since it's a small UI issue and the Web-E deploy can take another day or two. I'm checking it off. Can we retest this next week?

PR #9769 is failing due to #9769 (comment) - Any feedback if we can check it off? We are unable to verify.

I tested this on staging and could see the expensifail.com room. Checking it off
Screen Shot 2022-07-28 at 12 48 11 PM

@luacmartins
Copy link
Contributor

@mvtglobally any updates on the below?

PR #10092 Android was failing due to #10083. We are double checking now
and checking #10136 which just got added
We are also re-testing 3 Blockers as per your steps

@luacmartins
Copy link
Contributor

@mvtglobally

  1. I shared the android APK with you on Slack.
  2. Removed the blocker from the issues below since we didn't manage to reproduce them and they only affect beta features:

Let me know once QA finishes and we are ready to deploy!

@luacmartins luacmartins added the Daily KSv2 label Jul 29, 2022
@mvtglobally
Copy link

@luacmartins testers can still repro all issues on the build 1.1.86-5.

Record_2022-07-29-14-33-44_4f9154176b47c00da84e32064abf1c48.mp4
Image.from.iOS.7.mov
Record_2022-07-29-14-25-16_4f9154176b47c00da84e32064abf1c48.mp4
Record_2022-07-29-14-35-39_4f9154176b47c00da84e32064abf1c48.mp4

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2022

@luacmartins, @applausebot Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor

@yuwenmemon here’s the latest checklist. I think QA is still able to reproduce a few issues and based on this thread, we have a potential regression in App performance - https://expensify.slack.com/archives/C01GTK53T8Q/p1659018169624599

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2022
@luacmartins luacmartins removed their assignment Aug 1, 2022
@yuwenmemon
Copy link
Contributor

Sounds good - it looks like we need to start a fire-room as the deploy has been going on for more than 4 days now.

@yuwenmemon
Copy link
Contributor

Localize decimal separator was reverted so I'm checking it off

@ctkochan22
Copy link
Contributor

#9423 was mentioned in this comment as being retested, checking off #10077 (comment)

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@yuwenmemon @ctkochan22 @luacmartins @jasperhuangg @marcaaron @applausebot @mvtglobally @OSBotify