Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-10-17 #11920

Closed
10 tasks done
OSBotify opened this issue Oct 17, 2022 · 13 comments
Closed
10 tasks done

Deploy Checklist: New Expensify 2022-10-17 #11920

OSBotify opened this issue Oct 17, 2022 · 13 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 17, 2022 •
edited by sketchydroide

Release Version: 1.2.17-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@roryabraham
Copy link
Contributor

Please leave this unlocked for a few minutes for a live deploy test. Thanks

@roryabraham
Copy link
Contributor

Okay, you can lock and begin QA

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 17, 2022
@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.17-4 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.17-4 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.17-3 🚀

@Julesssss
Copy link
Contributor

Hi @Expensify/applauseleads we believe you are unable to check off 10994 because of the deploy blocker which blocks that flow, is that correct?

If so, I think we can mark it off and re-test once the backend fix is merged.

@mvtglobally
Copy link

@Julesssss Regression is almost completed

and you are right, PR #10994 is failing due to #11929

@Julesssss
Copy link
Contributor

Thanks. So I think the blocking issue should be checked off -- the remaining question is whether we can deploy without verifying the steps for #10994. Asking for a second opinion internally.

@sketchydroide
Copy link
Contributor

The last Item was fixed by the PR here

@sketchydroide
Copy link
Contributor

:shipit:

@OSBotify OSBotify reopened this Oct 19, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Oct 19, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@sketchydroide
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sketchydroide @Julesssss @applausebot @mvtglobally @roryabraham @OSBotify