Deploy Checklist: New Expensify 2023-10-31

[OSBotify]

Release Version: 1.3.94-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Show info about workspace members added by secondary logins #23702
• [No QA] Sorted import aliases #26605
• [TS migration] Migrate 'SelectionScraper' lib to TypeScript #27796
• Add subscribe to parent comment action menu #27994
• [No QA][TS migration] Migrate 'Welcome.js' lib to TypeScript #28381
• Add https to webpack dev server #28422
• Fix/28098: Clicking back button bring back the workspace #28573
• [TS migration] Migrate 'PolicyUtils.js' lib to TypeScript #28587
• [No QA] [TS migration] Migrate 'Environment' lib to TypeScript #28600
• Fix receipt image is opened in transaction thread report #28640
• Update Business-Bank-Accounts-USD.md #29014
• fixed offline jumping behaviour #29045
• [No QA] [TS Migration] Migrate useReportScrollManager and ReportScreenContext to TypeScript #29315
• [No QA] [TS migration] Migrate 'useArrowKeyFocusManager.js' hook to TypeScript #29328
• [TS migration] Migrate 'KeyboardShortcut' lib to TypeScript #29338
• RTL Text gets renderd properly #29434
• [TS migration] Migrate 'withPolicy.js' HOC to TypeScript #29554
• Add README section on how to add certificate to simulators #29754
• [NO QA][TS migration] Migrate 'RenderHTML.js' component to TypeScript #29756
• [TS migration] Migrate 'SignInPageForm' component to TypeScript #29765
• Added allOptions to scrollToIndex callback dependencies #29848
• 27456 Chat - The green line is displayed chaotically at the recipient #29860
• Rename shouldDisableWriteActions to canUserPerformWriteAction #29887
• Plaid popup continue to open from resume app  #29927
• Update request money header title #29936
• [No QA] [TS Migration] migrate KeyboardAvoidingView.js to TypeScript #29955
• [No QA][TS migration] Migrate 'RadioButtons.js' component to TypeScript #29970
• [Form Provider Refactor] AddDebitCardPage #29983
• [Form Provider Refactor] NewTaskDescriptionPage #30061
• Fix - mWeb/Safari- Chat - After tapping on "Copy to clipboard", options menu does not close #28820 #30085
• fix: console error old-dot to new-dot new workspace transition #30115
• [Form Provider Refactor] NewTaskTitlePage #30167
• fix: Settings - Long email address appears differently between Android native and mWeb #30173
• Update dependencies on desktop package file to fix vulnerabilities #30186
• enable maxHeight to avoid keyboard overlapping the save button #30238
• Design follow up to Tag and Category lists #30264
• fix error message positioning on amount page #30287
• fixed auto submit form when enter key pressed in selection modals #30300
• [No QA] Skip tests, lint and deploys for unrelated changes #30315
• Fix/29812: Same page has different error text color for different errors #30325
• Fix/28599: Trim the draft private note #30357
• Update Tags.md #30369
• [Form Provider Refactor] EditRequestDescriptionPage #30382
• Fix bug when editing any IOU information the date is automatically reduced by one #30410
• [Form Provider Refactor] MoneyRequestDescriptionPage #30419
• Fix/29854 #30429
• Fix: Wallet - Once after login, debit card page exits without open #30433
• Focus on the first item of the selection list when user changes the search input #30438
• [TS migration] Migrate 'SplashScreenHider' component to TypeScript #30439
• [Form Provider Refactor] IntroSchoolPrincipalPage #30444
• Fix pressing the task report (with assignee) header opens the assignee profile page #30452
• Fix skeleton animation on web #30458
• [Fix][Web] App crash on device toolbar toggle #30462
• Add server-side report searching for task destination and money requests #30471
• Update Lounge Access page #30473
• Fix: FAB - New workspace option disappears from FAB in offline mode #30475
• Fix selection includes SVG style and data-testid value #30476
• Generate error when request money failure #30477
• Category-Long category is truncated although space available #30479
• [CP Staging] Fix viewing attachments #30481
• fix: don't focus composer if emoji picker is opened #30483
• [NoQA] [DEV] E2e/increase reliability #30484
• fix: set null to unread marker when there are no new messages #30485
• chore: use optionRowHeight instead of paymentMethodHeight #30486
• fix: offline indicator inside a keyboard avoiding view #30491
• [TS Migration] Style fixes in Text.tsx #30497
• [CP Staging] Revert optimization on image, ignore in the future #30512
• Update formatting per prettier #30519
• emoji/mention suggestion are displayed #30521
• [No QA] Include more paths in lint workflow #30522
• description/comment to string #30526
• [HelpDot] Style markdown tables #30530
• Revert "[Form Provider Refactor] RoomNameInput" #30532
• Update QuickBooks-Online.md #30534
• [CP Stag] Fix: crash on click of Error message CTA #30536
• Update "Remaining spending power" to "Remaining limit" #30542
• [NoQA] [DEV] Prevent babel from failing when CAPTURE_METRICS true #30566
• Remove openreport api calls while switching windows #30572
• rename lastFourDigits to cardLastFourDigits for API call #30573
• BA icon style fix #30589
• Migrate MacOS desktop to use notarytool to notarize #30599
• Rodrigo fix shortcut bindings #30602
• [No QA] Clean up for added by secondary login messages #30604
• Add a basic sitemap #30612
• [No QA] Fix ncc builds #30614
• Fix incorrect command name for RevealDetails button #30647
• [No QA] Delete docs/articles/expensify-classic/expensify-card/CPA-Card.md #30651
• Revert "[Form Provider Refactor] AddDebitCardPage" #30708
• [CP Staging] Revert "27456 Chat - The green line is displayed chaotically at the recipient" #30712

Deploy Blockers:

• [$500] Thread - Admin lands in [Delete message] after login when employee subscribes to welcome message #30666
• [HOLD for payment 2023-11-13] [HOLD for payment 2023-11-09] [$500] Chat - Tapping "Mark as unread option" not showing green line above message #30684
• [HOLD for payment 2023-11-13] [HOLD for payment 2023-11-09] Unread message - When delete unread message green line blinks and goes to the next message #30696
• [HOLD for payment 2023-12-06] [HOLD for payment 2023-11-28] Wallet - After tapping on the debit card number field, an error message appears #30703
• [HOLD for payment 2023-12-15] [$500] IOS - A spinner appears in the chat when a message is posted #30729

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.94-0 🚀

[kavimuru]

Checking off the following PRs from the past builds.

#23702
#27994
#28587
#29014
#29338
#29434
#29765
#29848
#29927
#29936
#30186
#30287
#30357
#30369
#30462
#30481
#30486
#30497
#30512
#30521
#30532
#30534
#30536

[Beamanator]

Ran this script again to de-dupe, got this output:

Output:

- [x] https://github.com/Expensify/App/pull/23702
- [x] https://github.com/Expensify/App/pull/26605
- [ ] https://github.com/Expensify/App/pull/27796
- [x] https://github.com/Expensify/App/pull/27994
- [x] https://github.com/Expensify/App/pull/28381
- [ ] https://github.com/Expensify/App/pull/28422
- [ ] https://github.com/Expensify/App/pull/28573
- [x] https://github.com/Expensify/App/pull/28587
- [x] https://github.com/Expensify/App/pull/28600
- [ ] https://github.com/Expensify/App/pull/28640
- [x] https://github.com/Expensify/App/pull/29014
- [ ] https://github.com/Expensify/App/pull/29045
- [x] https://github.com/Expensify/App/pull/29315
- [x] https://github.com/Expensify/App/pull/29328
- [x] https://github.com/Expensify/App/pull/29338
- [x] https://github.com/Expensify/App/pull/29434
- [ ] https://github.com/Expensify/App/pull/29554
- [ ] https://github.com/Expensify/App/pull/29754
- [x] https://github.com/Expensify/App/pull/29756
- [x] https://github.com/Expensify/App/pull/29765
- [x] https://github.com/Expensify/App/pull/29848
- [ ] https://github.com/Expensify/App/pull/29860
- [ ] https://github.com/Expensify/App/pull/29887
- [x] https://github.com/Expensify/App/pull/29927
- [x] https://github.com/Expensify/App/pull/29936
- [x] https://github.com/Expensify/App/pull/29955
- [x] https://github.com/Expensify/App/pull/29970
- [ ] https://github.com/Expensify/App/pull/29983
- [ ] https://github.com/Expensify/App/pull/30061
- [ ] https://github.com/Expensify/App/pull/30085
- [ ] https://github.com/Expensify/App/pull/30115
- [ ] https://github.com/Expensify/App/pull/30167
- [ ] https://github.com/Expensify/App/pull/30173
- [x] https://github.com/Expensify/App/pull/30186
- [ ] https://github.com/Expensify/App/pull/30238
- [ ] https://github.com/Expensify/App/pull/30264
- [x] https://github.com/Expensify/App/pull/30287
- [ ] https://github.com/Expensify/App/pull/30300
- [x] https://github.com/Expensify/App/pull/30315
- [ ] https://github.com/Expensify/App/pull/30325
- [x] https://github.com/Expensify/App/pull/30357
- [x] https://github.com/Expensify/App/pull/30369
- [ ] https://github.com/Expensify/App/pull/30382
- [ ] https://github.com/Expensify/App/pull/30410
- [ ] https://github.com/Expensify/App/pull/30419
- [ ] https://github.com/Expensify/App/pull/30429
- [ ] https://github.com/Expensify/App/pull/30433
- [ ] https://github.com/Expensify/App/pull/30438
- [ ] https://github.com/Expensify/App/pull/30439
- [ ] https://github.com/Expensify/App/pull/30444
- [ ] https://github.com/Expensify/App/pull/30452
- [ ] https://github.com/Expensify/App/pull/30458
- [x] https://github.com/Expensify/App/pull/30462
- [ ] https://github.com/Expensify/App/pull/30471
- [ ] https://github.com/Expensify/App/pull/30473
- [ ] https://github.com/Expensify/App/pull/30475
- [ ] https://github.com/Expensify/App/pull/30476
- [ ] https://github.com/Expensify/App/pull/30477
- [ ] https://github.com/Expensify/App/pull/30479
- [ ] https://github.com/Expensify/App/pull/30481
- [ ] https://github.com/Expensify/App/pull/30483
- [x] https://github.com/Expensify/App/pull/30484
- [ ] https://github.com/Expensify/App/pull/30485
- [x] https://github.com/Expensify/App/pull/30486
- [ ] https://github.com/Expensify/App/pull/30491
- [x] https://github.com/Expensify/App/pull/30497
- [ ] https://github.com/Expensify/App/pull/30512
- [x] https://github.com/Expensify/App/pull/30519
- [x] https://github.com/Expensify/App/pull/30521
- [x] https://github.com/Expensify/App/pull/30522
- [ ] https://github.com/Expensify/App/pull/30526
- [ ] https://github.com/Expensify/App/pull/30530
- [ ] https://github.com/Expensify/App/pull/30532
- [x] https://github.com/Expensify/App/pull/30534
- [ ] https://github.com/Expensify/App/pull/30536
- [ ] https://github.com/Expensify/App/pull/30542
- [x] https://github.com/Expensify/App/pull/30566
- [ ] https://github.com/Expensify/App/pull/30572
- [ ] https://github.com/Expensify/App/pull/30573
- [ ] https://github.com/Expensify/App/pull/30589
- [ ] https://github.com/Expensify/App/pull/30599
- [ ] https://github.com/Expensify/App/pull/30602
- [x] https://github.com/Expensify/App/pull/30604
- [ ] https://github.com/Expensify/App/pull/30612
- [x] https://github.com/Expensify/App/pull/30614
- [ ] https://github.com/Expensify/App/pull/30647
- [x] https://github.com/Expensify/App/pull/30651

[Beamanator]

Another weird point to mention: All of the PRs in this list marked CP Staging were already in prod a few days ago 🤷 so I checked them off the above list (also #30532 which was CP'd)

[Beamanator]

Currently no blockers 👍

[Beamanator]

Testflight still shows the old version (1.3.93.1) - i'll try to update to 1.3.94.0 now

[Beamanator]

Discussed a bit in this thread - it seems 1.3.94.0 is available to some users via testflight already, just not everyone (ex: me) 🤷 👍

[kavimuru]

Regression 78% progress.
#30264 failing with #30222 in Desktop and Web, This is a KI checking off
#30476 failing with #30681 repro in PROD checking off
#30479 failing with #30222 ( not fixed)
#30485 failing with #30684

[kavimuru]

@Beamanator This PR seems to be internal #30573 (comment)

[Beamanator]

@kavimuru I agree, I checked off #30573 👍

[Beamanator]

Checking off #29983 b/c we reverted it in #30708 (& checking off that one too)

[kavimuru]

Regression we are down to 4%. Validating cps

[kavimuru]

Regression is left with 10 steps.
#30712 failing with #30696 (Not fixed in Android)
#30479 failing with #30222 ( not fixed)
#30485 failing with #30684

[mvtglobally]

Regression is completed

[Beamanator]

Checking off #30729 as it was confirmed this happens in prod here

[Beamanator]

Checked off #30703 b/c it was fixed via #30708 & tested 👍

[Beamanator]

#30222 reproducible in prod, so checking off #30479

[Beamanator]

Checking off #30485 and #30684 b/c it is fixed in staging, via #30712

[Beamanator]

Checking off #30696 b/c it's a super small bug & it's better than before, and should be fixed via #25935

[Beamanator]