[$250] [Track Tax] The tax amount of a manual IOU will be in negative format

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause - Internal Team

Issue found whene executing PR #41264

Action Performed:

1. Open https://staging.new.expensify.com/
2. Log in to your HT account
3. Create a WS
4. Enable "Taxes"
5. Set "Tax Rate 1" as Workspace currency default
6. Navigate to the WS room
7. Create any manual IOU
8. Create another manual IOU with a default currency and a Tax Rate 1
9. Navigate to the details of the last IOU created
10. Change the tax amount to any valid amount
11. Start creating a new manual IOU
12. Navigate to the tax amount entry menu

Expected Result:

The tax amount when creating a manual IOU should not be in a negative format

Actual Result:

After editing the Tax amount in an existing IOU, the next time a manual IOU is created, the Tax amount in the edit menu will be in negative format

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6467975_1714572153780.Recording__113.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010f30064172acce83
• Upwork Job ID: 1786430749556625408
• Last Price Increase: 2024-05-03
• Automatic offers:
• hoangzinh | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tax amount is shown in negative value.

What is the root cause of that problem?

The tax amount is taken from getTaxAmount.

App/src/libs/TransactionUtils.ts

Lines 301 to 310 in 12042db

	function getTaxAmount(transaction: OnyxEntry<Transaction>, isFromExpenseReport: boolean): number {
	// IOU requests cannot have negative values but they can be stored as negative values, let's return absolute value
	if (!isFromExpenseReport) {
	return Math.abs(transaction?.taxAmount ?? 0);
	}
	// To avoid -0 being shown, lets only change the sign if the value is other than 0.
	const amount = transaction?.taxAmount ?? 0;
	return amount ? -amount : 0;
	}

For an expense report, we negate the amount value. The reason is explained in the comment in getAmount, that is, the amount for the expense report is stored in negative value.

App/src/libs/TransactionUtils.ts

Lines 285 to 287 in 12042db

	// Expense report case:
	// The amounts are stored using an opposite sign and negative values can be set,
	// we need to return an opposite sign than is saved in the transaction object

That's true, but it's only when the request is created.

App/src/libs/actions/IOU.ts

Lines 1817 to 1818 in c5a1f96

	let optimisticTransaction = TransactionUtils.buildOptimisticTransaction(
	ReportUtils.isExpenseReport(iouReport) ? -amount : amount,

While we are creating the request, the amount is still in positive value, so negating it will give us a negative tax amount.

This doesn't happen on the amount page because we always return the absolute value.

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 287 in c5a1f96

amount={Math.abs(transactionAmount)}

What changes do you think we should make in order to solve the problem?

Do the same as what we did on the amount page, that is return the absolute value of the amount.
Math.abs(transactionDetails?.taxAmount)

What alternative solutions did you explore? (Optional)

If we are creating a new request, don't negate the amount value.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010f30064172acce83

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[alexpensify]

@hoangzinh - when you get a chance, can you review if this proposal will fix this issue? Thanks!

---

Heads up, I will be offline until Tuesday, May 7, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

[melvin-bot]

@alexpensify, @hoangzinh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

@hoangzinh any update regarding the proposal? Thanks!

[hoangzinh]

sorry for late update. @bernhardoj proposal looks good to me #41418 (comment). I think we should go with his main solution.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hayata-suenaga]

the proposal looks good to me. we can return the absolute value 👍

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @hoangzinh

[alexpensify]

@hoangzinh, please keep us posted if you are unable to review this PR. Thanks!

[hoangzinh]

@alexpensify I can review this PR today or tomorrow.

[alexpensify]

Thank you for that update!

[alexpensify]

@hoangzinh any news here? Thanks!

[hoangzinh]

@bernhardoj opened PR and we're nearly done with the PR but the issue has been fixed in another PR #42039 already with the same solution with @bernhardoj. Therefore, I think we should put this issue on the regression period and process payment for Contributor and C+.

[alexpensify]

Thanks for that summary!

[alexpensify]

Payouts due: TBD

• Contributor: $250 @bernhardoj
• Contributor+: $250 @hoangzinh

Upwork job is here.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

@greg-schroeder - Here is the payment summary - #41418 (comment). While I'm offline, I need help here completing the payment process after this one clears the 7-day period. Thanks!

[greg-schroeder]

Hmm. Honestly, I don't think we need to put this in the regression period for #42039 as the contributors in this issue aren't necessarily beholden to that code's performance. And any regressions will be handled by the authors of that PR. I'll pay out the offers for your work now @hoangzinh @bernhardoj

[alexpensify]

Thanks, @greg-schroeder, for your help here!

[greg-schroeder]

i gotchu @alexpensify!