-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete iou report along with expense #42031
Conversation
@nkdengineer During testing, after I deleted the expense, it showed [Deleted report], and then it changed to a preview with a value of 0.00 afterwards. Can you check this? Screen.Recording.2024-05-13.at.13.51.55.mp4 |
@nkdengineer can you show a screenshot of the network request. What is it returning that isn't |
@blimpich Let see the image below, after Screen.Recording.2024-05-15.at.17.58.29.mov |
I believe that is intended. See this comment. We no longer mark the report as closed in the backend in this case, we instead convert it to a chat. @amyevans can you confirm that |
Correct, the statusNum should be open/0. But yes we may need a backend change to handle the conversion of the report type to |
Ah yeah I see, the type is still marked as "expense" and not "chat" in that response. I'll look into this today. Thank you Amy! |
@blimpich So what is the next step here? |
I think we close this PR. I'm sorry @nkdengineer, I should have spent more time understanding recent changes on the backend to know that this approach wouldn't work. I will try to be more informed and careful in the future. |
Details
Fixed Issues
$ #41656
PROPOSAL: #41656 (comment)
Tests
[Deleted report]
Offline tests
Same as above
QA Steps
[Deleted report]
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-05-13.at.11.13.17.mov
Android: mWeb Chrome
Screen.Recording.2024-05-13.at.10.59.37.mov
iOS: Native
Screen.Recording.2024-05-13.at.11.14.30.mov
iOS: mWeb Safari
Screen.Recording.2024-05-13.at.11.05.35.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-13.at.10.57.29.mov
MacOS: Desktop
Screen.Recording.2024-05-13.at.11.16.47.mov