Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book Travel - Book Travel - Links lead to 404 error page #42203

Closed
1 of 6 tasks
lanitochka17 opened this issue May 15, 2024 · 5 comments
Closed
1 of 6 tasks

Book Travel - Book Travel - Links lead to 404 error page #42203

lanitochka17 opened this issue May 15, 2024 · 5 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented May 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the New Expensify App
  2. Sign into a valid account (That will show Book Travel option in the FAB menu)
  3. Click on Book Travel > Book Travel Again in the popup modal
  4. Click on the Terms & Cond Button on the top or bottom

Expected Result:

User expects the Terms page to open and load

Actual Result:

User is taken to a 404 error page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481868_1715793211099.Links_lead_to_error_page_.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 15, 2024
Copy link

melvin-bot bot commented May 15, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@gijoe0295
Copy link
Contributor

gijoe0295 commented May 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is taken to a 404 error page when opening travel terms & conditions

What is the root cause of that problem?

We're opening https://use.expensify.com/travelterms which might not be deployed or incorrect.

What changes do you think we should make in order to solve the problem?

Replace with correct link.

I also notice a small UI issue is that the dot here is also wrapped in the TextLink, we should move it out.

Screenshot 2024-05-16 at 01 14 29

@kadiealexander
Copy link
Contributor

I think this is expected because we haven't deployed the T&Cs yet, checking here.

@kadiealexander
Copy link
Contributor

This is expected, and will self-resolve once the Travel Terms page is launched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants