[HOLD for payment 2024-06-03] [$250] Web -Split - Split amount is not selected when clicking or double clicking on the input

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to https://42057.pr-testing.expensify.com/ - also reproducible in staging
2. Go to FAB > Split expense.
3. Enter amount and select participants.
4. On confirmation page, double click on the split amount input.

Expected Result:

The value in the input will be selected.

Actual Result:

The value in the input is not selected.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

330486260-b37352d7-d18d-4289-ba35-d829ad59c85c.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0176e8fca3d0f13f91
• Upwork Job ID: 1790855337333891072
• Last Price Increase: 2024-05-15
• Automatic offers:
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The value in the input is not selected.

What is the root cause of that problem?

• In here, we are using shouldPreventDefaultFocusOnSelectRow: true

What changes do you think we should make in order to solve the problem?

• Just need to add the below to this:

            onMouseDown={(event)=>event.stopPropagation()}

What alternative solutions did you explore? (Optional)

• NA

[neil-marcellini]

👀 taking a look now

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0176e8fca3d0f13f91

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[neil-marcellini]

@nkdengineer thanks for the proposal! I set the prop to false on the MoneyRequestConfirmationList page and I see that it fixes the issue. I also see that it was added recently with this PR feat: refactor MoneyRequestConfirmationList. For a quick fix we could just revert that one.

Could you please explain a bit more about why it's ok to set it false?

It looks like we usually set that prop with this value !DeviceCapabilities.canUseTouchScreen(). I think we should probably do that. Edit: Actually I guess that wouldn't work, because it would be true for web on a computer.

[neil-marcellini]

I'll assign you and you can get started on a PR @nkdengineer

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[neil-marcellini]

@nkdengineer that seems like it could be a good approach. If you would like to put up an alternative to my PR, please go ahead and do so. If the C+ finds problems with mine we could go with your approach.

I'm going to move on to other things for the rest of the day but I'll check back tomorrow.

[nkdengineer]

I opened the PR based on comment here

[nkdengineer]

Also, I updated proposal to match this comment

[Beamanator]

Bumped @rushatgabhane in slack

[Beamanator]

PR was just CP'd to staging, I'll test

[Beamanator]

Fixed on staging 👍

[neil-marcellini]

@strepanier03 would you please handle payment? For some reason that automation didn't run to update the title.

[nkdengineer]

@neil-marcellini Can you reassign me to this issue based on comment here

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix Split amount is not selected #42237

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[nkdengineer]

@neil-marcellini Can you assign me to this issue?

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: [TS migration] Migrate 'SelectionList' component to TypeScript #34008

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [TS migration] Migrate 'SelectionList' component to TypeScript #34008 (review)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. Yes

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

            1. Open app
            2. Go to FAB > Split expense.
            3. Enter amount and select participants.
            4. On confirmation page, double click on the split amount input.
            5. The value in the input will be selected.
   

[rushatgabhane]

@strepanier03 could you please attach payment summary, thank you!