-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Chat - Scan - Extra padding above the error "Enter an amount" #42209
Comments
Triggered auto assignment to @puneetlath ( |
Triggered auto assignment to @miljakljajic ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it. |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Extra padding above the error "Enter an amount" What is the root cause of that problem?We pass the style App/src/components/MenuItem.tsx Line 688 in 4705d89
Which has the extra Lines 4479 to 4480 in 4705d89
The marginTop adds on to the margin App/src/components/FormHelpMessage.tsx Line 39 in ac2b3a0
What changes do you think we should make in order to solve the problem?We should set the marginTop to marginTop: 0 This would reset the extra mt2 here |
@neonbhai good catch, did you find which PR introduced this bug? I'm also going to mark NAB b/c this is a pretty small spacing bug which shouldn't block deploy |
@Beamanator hi, this seems to be related to the work we did in #41670 |
Good find @neonbhai ! I think I found where exactly, noted here: https://github.com/Expensify/App/pull/41670/files#r1602998785 |
@neonbhai @Beamanator that's a new UI change - and it's correct padding. Please check this one #41670 (comment) |
Correct, just going to close this out then! |
@Beamanator in the future, please tag the design team to help confirm if these things are bugs or not - thanks! |
Thanks for pointing that out @narefyev91 ! 👍 And good shout @shawnborton 😅 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
There will be no extra padding above the error "Enter an amount".
Actual Result:
There is extra padding above the error "Enter an amount".
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
330490244-56258565-80d6-4eef-bc92-54cded7fc652.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: