-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mWeb - Chat - In offline, emojis are not striked out when deleted with markdown #42212
Comments
Triggered auto assignment to @laurenreidexpensify ( |
@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
@Expensify/design curious for your thoughts here - this doesn't seem like a bug worth addressing ? |
ProposalPlease re-state the problem that we are trying to solve in this issue.The deleted message with emoji inside a markdown doesn't get strikethrough. What is the root cause of that problem?In #40617, we prevent the emoji to be formatted (bold, italic, strikethrough), so if we type
What changes do you think we should make in order to solve the problem?If we want to show the strikethrough only when the message is deleted, first, convert
To know whether it's deleted or not, we can add
Then, check whether
We need to apply it to InlineCodeBlock and WrappedText too. What alternative solutions did you explore? (Optional)Create a new context to hold the deleted message value, wrap the context here, App/src/pages/home/report/comment/TextCommentFragment.tsx Lines 66 to 71 in 4499fa2
and access the context (useContext) in EmojiRenderer, InlineCodeBlock, and WrappedText. |
Yeah, interesting one. It is "breaking the pattern" insofar as not providing feedback that it's pending to be deleted with strikethrough, but being greyed out is signalling there's a change pending to happen. I think it's fine to not apply strikethrough to the emoji in the offline case, the same as we don't allow it via markdown. We do something similar with a custom avatar you delete when offline, we don't put strikethrough through your profile pic while it's pending to be deleted - it's just greyed out because it looks weird otherwise. So I think we can close this personally 👍 |
Yeah, I'm cool with that too. Feels pretty edge case as well. |
Same here. I'm good with closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.74
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4562779
Issue reported by: Applause - Internal Team
Action Performed:
Pre-condition: Be in offline
Expected Result:
In offline, emojis must be strike out when deleted with markdown
Actual Result:
In offline, emojis are not striked out when deleted with markdown
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6481989_1715802082296.emoji.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: