Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare error for loading an image attachment says receipt when the site is down #42230

Closed
1 of 6 tasks
m-natarajan opened this issue May 15, 2024 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented May 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @twisterdotcom
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715785965607169

Action Performed:

Precondition : Site is down

  1. Open a report and send an attachment
  2. Observe the error message for server error

Expected Result:

Should say 500 server error

Actual Result:

Shows as error occurred while fetching this receipt. Please try again or contact ....

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image
Correct image : https://github.com/Expensify/Web-Static/blob/main/images/receipts.forbidden.500.png

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels May 15, 2024
Copy link

melvin-bot bot commented May 15, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
Copy link

melvin-bot bot commented May 21, 2024

@anmurali Huh... This is 4 days overdue. Who can take care of this?

@twisterdotcom
Copy link
Contributor

I haven't been able to recreate... which probably is a good thing, but seems we don't know where these assets are right @justinpersaud?

@justinpersaud
Copy link
Contributor

Yeah I have no idea because we thought we already updated the places where this image came from. Maybe it was some old cache?

@anmurali
Copy link

@twisterdotcom so do we wanna close this now?

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@twisterdotcom
Copy link
Contributor

Let's close yeah.

@justinpersaud
Copy link
Contributor

Able to reproduce this now while looking into another issue related to #fireroom-2024-04-29-siteslows

https://www.expensify.com/receipts/asidhsaoidhiodshoias.jpg

I'll take this and dig into it

@justinpersaud
Copy link
Contributor

cc @shawnborton @dannymcclain since you reported the above too

@justinpersaud
Copy link
Contributor

Ok should be fixed. We cache the Web-Static assets pretty much forever, so even though we updated this a month ago, the cache was still in place. I just purged it and now I'm seeing the updated URL with a forced refresh.

@shawnborton
Copy link
Contributor

Dope, thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

6 participants