-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-11] [HOLD for payment 2024-06-06] [$250] Distance Expense - Map is not centered over San Francisco when location settings are turned off #42236
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it. |
Triggered auto assignment to @luacmartins ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
This is pretty small and NAB. |
Job added to Upwork: https://www.upwork.com/jobs/~015240613a85d23a6c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
Triggered auto assignment to @slafortune ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The map is shown over my current city What is the root cause of that problem?User location is cached in Onyx so when we revoked location permission, the previous location was still there. When location request failed, we ran a callback to reset to App/src/components/MapView/MapView.website.tsx Lines 67 to 69 in 0d45c55
What changes do you think we should make in order to solve the problem?We need to reset location if permission was not granted by removing the We also need to clear the location stored in Onyx for privacy. We should only save user location as long as they permit it. Otherwise, we might get flickering between the cached location and the current or initial location. if (!initialState) {
return;
}
UserLocation.clear();
setCurrentPosition(initialState.location); What alternative solutions did you explore? (Optional)We can optionally check for App/src/libs/getCurrentPosition/getCurrentPosition.types.ts Lines 21 to 23 in c5f84b6
There's another issue that when there's cached location and the permission was reset, while the permission prompt was still open, the map would show the cached location instead of default location (San Francisco) because
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The map is shown over my current city when user geolocation settings are disabled What is the root cause of that problem?
App/src/components/MapView/MapView.website.tsx Lines 67 to 69 in 0d45c55
What changes do you think we should make in order to solve the problem?We should check for an error code returned from the if (error.code !== GeolocationErrorCode.PERMISSION_DENIED && (cachedUserLocation || !initialState)) {
return;
} What alternative solutions did you explore? (Optional)Screenshots/VideosScreen.Recording.2024-05-16.at.09.mp4 |
Proposal updated to add optional solution and detailed explaination. |
Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
Update: Awaiting @luacmartins to sign off the proposal |
There is a PR draft in review. I'll be out until June 4th - so adding another BZ in the meantime. I'll take this back on the 4th if needed. |
Triggered auto assignment to @jliexpensify ( |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@fedirjh any regressions here? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-06. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Ok, is this a correct Summary? Just waiting on the checklist (if applicable) |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-11. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4561935
Email or phone of affected tester (no customers): applausetester+azadmin@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The map is centered over San Francisco
Actual Result:
The map is shown over my current city
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6482032_1715806856342.map_San_Fransico.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @jliexpensifyThe text was updated successfully, but these errors were encountered: