Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access wideners should know their namespace #3

Open
Chocohead opened this issue Oct 29, 2020 · 0 comments
Open

Access wideners should know their namespace #3

Chocohead opened this issue Oct 29, 2020 · 0 comments

Comments

@Chocohead
Copy link

Chocohead commented Oct 29, 2020

As mentioned on Discord, ever since FabricMC/fabric-loader@69f3edf, AccessWidenerReader#read doesn't need the currentNamespace and will ignore the access widener's if it isn't given. This seems unwise given if the active namespace genuinely isn't known, there is also no way of knowing whether the access widener being read is actually useful.

In Loader's case the access widener being read is remapped using a remapper mapping from intermediary mappings anyway, so it was known and AccessWidener never needed to be changed to allow null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant