Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't tick gametests if the server isn't ticking #3528

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

jaredlll08
Copy link
Contributor

@jaredlll08 jaredlll08 commented Jan 14, 2024

The vanilla code now includes that shouldTick call.

@deirn deirn added enhancement New feature or request small change labels Jan 14, 2024
@deirn deirn requested a review from a team January 14, 2024 07:25
@apple502j apple502j added bug Something isn't working and removed enhancement New feature or request labels Jan 14, 2024
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot, thanks.

@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Jan 14, 2024
@modmuss50 modmuss50 merged commit 85d85a9 into FabricMC:1.20.4 Jan 15, 2024
modmuss50 pushed a commit that referenced this pull request Jan 15, 2024
* Don't tick gametests if the server isn't ticking

* Fix import order

(cherry picked from commit 85d85a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge me please Pull requests that are ready to merge small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants