Fix login network addons not properly initialized #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
added
bug
modmuss50
approved these changes
Jan 15, 2024
modmuss50
pushed a commit
that referenced
this pull request
Jan 17, 2024
(cherry picked from commit bf1eca5)
modmuss50
pushed a commit
that referenced
this pull request
Jan 17, 2024
(cherry picked from commit bf1eca5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3530
In #3394 the addition of global receivers is moved to
AbstractNetworkAddon#lateInit, but it never gets called for login addons.This also fixes the login
INITevents not being called.Needs to also be backported to 1.20.2.