Expose a function for querying the non-default fluid renderer #3558
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This does introduce one difference, being that the renderer will now always invoke the fluid handler for water/lava fluids in |
Technici4n
reviewed
Feb 1, 2024
...c/client/java/net/fabricmc/fabric/api/client/render/fluid/v1/FluidRenderHandlerRegistry.java
Show resolved
Hide resolved
modmuss50
approved these changes
Feb 5, 2024
PepperCode1
reviewed
Feb 5, 2024
...c/client/java/net/fabricmc/fabric/api/client/render/fluid/v1/FluidRenderHandlerRegistry.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request exposes the existing functionality located at
FluidRenderHandlerRegistryImpl#getOverrideso that other mods can use it without depending on internals.The reason for this is because Sodium (see issue) implements its own "default" for fluids, which allows it to use per-vertex colors to create a smooth gradient across the water surface. Since it's currently not possible to detect whether the default implementation is being returned by Fabric API, we can't know when to override it with our own in rendering.
I'm not sure if this is the best solution, but it seems relatively harmless as far as changes go.