Fluid rendering fixes #3593
Merged
Fluid rendering fixes #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix default overlay block check using TransparentBlock instead of TranslucentBlock - Fix setBlockTransparency/isBlockTransparent not being thread-safe - Reuse the same render handler objects for water and lava
- Fix custom geometry being buffered twice if FluidRenderHandler#renderFluid is invoked directly - Fix calling FluidRenderHandler.super.renderFluid not using passed arguments to calculate color - Fix calling FluidRenderHandler.super.renderFluid more than once producing incorrect geometry - Fix fluids with no handler never receiving water overlay instead of using default behavior
modmuss50
added
bug
modmuss50
approved these changes
Feb 16, 2024
- Fix testmod
Technici4n
approved these changes
Feb 17, 2024
modmuss50
pushed a commit
that referenced
this pull request
Feb 18, 2024
* Fluid rendering fixes - Fix default overlay block check using TransparentBlock instead of TranslucentBlock - Fix setBlockTransparency/isBlockTransparent not being thread-safe - Reuse the same render handler objects for water and lava * Fix implementation issues - Fix custom geometry being buffered twice if FluidRenderHandler#renderFluid is invoked directly - Fix calling FluidRenderHandler.super.renderFluid not using passed arguments to calculate color - Fix calling FluidRenderHandler.super.renderFluid more than once producing incorrect geometry - Fix fluids with no handler never receiving water overlay instead of using default behavior * Add way to render fluid with non-vanilla default - Fix testmod (cherry picked from commit e761c66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransparentBlockinstead ofTranslucentBlock(fix Ice/Honey block/Slime block/Frosted Ice cause water to show flowing animation at the sides #3592)setBlockTransparency/isBlockTransparentnot being thread-safeFluidRenderHandler#renderFluidis invoked directlyFluidRenderHandler.super.renderFluidnot using passed arguments to calculate colorFluidRenderHandler.super.renderFluidmore than once producing incorrect geometryFluidRendering#render, which allows invokingFluidRenderHandler#renderFluidwith a specified, possibly non-vanilla default renderer