Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url extension http va https #24

Open
pimjansen opened this issue Jan 17, 2023 · 4 comments · May be fixed by #27
Open

Url extension http va https #24

pimjansen opened this issue Jan 17, 2023 · 4 comments · May be fixed by #27
Labels
enhancement New feature or request

Comments

@pimjansen
Copy link
Contributor

At this point only http urls are generated. We should check how we can handle https etc as well

@pimjansen pimjansen added the enhancement New feature or request label Jan 17, 2023
@pimjansen
Copy link
Contributor Author

@bram-pkg will we even include those random urls? This due the fact that we don't own a TLD which can cause it generating real URL's ofcourse. What is your view?

@bram-pkg
Copy link
Member

Do you think it would be too limited to generate only urls for: https://www.rfc-editor.org/rfc/rfc2606.html#section-3

The Dutch also have https://example.nl which is maintained by the company that runs the .nl top level domain nameservers.

@pimjansen
Copy link
Contributor Author

Do you think it would be too limited to generate only urls for: https://www.rfc-editor.org/rfc/rfc2606.html#section-3

The Dutch also have https://example.nl which is maintained by the company that runs the .nl top level domain nameservers.

Nope so nice find. Guess it is ok as long as we document it right. I will add an url extension for this

@pimjansen pimjansen linked a pull request Jan 18, 2023 that will close this issue
@websitevirtuoso
Copy link

any news?

I had to write my custom function to use https.

laravel has option to check if https link

        'website_url' => 'nullable|string|url:https',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants