Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in BufferRecycler.allocByteBuffer(int,int), wrong default size #143

Closed
cowtowncoder opened this issue Jun 6, 2014 · 0 comments
Closed

Bug in BufferRecycler.allocByteBuffer(int,int), wrong default size #143

cowtowncoder opened this issue Jun 6, 2014 · 0 comments

Comments

@cowtowncoder
Copy link
Member

Looks like refactoring between 2.3.3 and 2.4.0 broke handling of allocation of non-default buffers; what happens is that allocated buffer size ends up being default even if caller specifies alternate minimum size.

This ends up causing performance regression for jackson-dataformat-cbor (but not other encoders, at least not json or smile) since it defaults to bigger buffer size for write encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder