Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven wrapper #732

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Update Maven wrapper #732

merged 2 commits into from
Dec 31, 2021

Conversation

asomov
Copy link
Contributor

@asomov asomov commented Dec 19, 2021

No description provided.

@cowtowncoder
Copy link
Member

Hi @asomov! Could you elaborate a bit on this one? Is this just a newer recommended version of wrapper or... ? Is there a blog post or article explaining what is the benefit?

@asomov
Copy link
Contributor Author

asomov commented Dec 22, 2021

@cowtowncoder Maven Wrapper is now not from io/takari but from Apache
The JAR was removed from GIT (I do not like binaries in GIT)
Functionality is identical.

@cowtowncoder
Copy link
Member

Ok, but is this basically following a more up-to-date explanation of sort of "standard" Maven wrapper usage?
I would just like to know the source if so, and perhaps make similar changes for other repos.
It is not that I do not trust you or set up but want to know the source.

@asomov
Copy link
Contributor Author

asomov commented Dec 23, 2021

@cowtowncoder yes, it is just standard way now

@cowtowncoder
Copy link
Member

@asomov Before merging this, I really need to see the instructions of how to set this up. All instructions I googled for go with Takari plug-in, f.ex:

all claim one should use:

mvn -N io.takari:maven:0.7.7:wrapper

and if there is a newer, better way, I want to know that so I can repeat the process.
I cannot (or rather, should not) just copy files if and when there is a process to use to get pieces added.

So... do you know of an article, blog post, github repo that shows how to do this?

@asomov
Copy link
Contributor Author

asomov commented Dec 28, 2021

@cowtowncoder it was before it became part of Apache (it was takari).
Now it is simpler:

mvn wrapper:wrapper
(make sure you do not add JAR to GIT - it will be downloaded when you run it the first time)

@asomov
Copy link
Contributor Author

asomov commented Dec 28, 2021

It allows all the developers and the CI use exactly the same version of Maven (the same plugins)

@cowtowncoder
Copy link
Member

@asomov Ah! thank you very much. This makes sense. I'll merge this then.

@cowtowncoder cowtowncoder changed the base branch from master to 2.13 December 31, 2021 22:25
@cowtowncoder cowtowncoder added 2.10 and removed 2.10 labels Dec 31, 2021
@cowtowncoder cowtowncoder merged commit 2510349 into FasterXML:2.13 Dec 31, 2021
cowtowncoder added a commit that referenced this pull request Dec 31, 2021
cowtowncoder added a commit that referenced this pull request Dec 31, 2021
@cowtowncoder
Copy link
Member

Ugh. Sorry, I botched this one, trying to rebase and ending up temporarily merging ... yeah. 3.0 stuff in, it seems. Not sure why, actually, but I guess I'll stick to cherry-picking going forward.

Will use generation mechanism suggested on branch 2.13, idea being I'd like to backport this so it's not only used for master (which is for Jackson 3.0.0).

cowtowncoder added a commit that referenced this pull request Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants