Limit size of exception message in BigDecimalParser #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
changed the title
cowtowncoder
reviewed
Apr 1, 2022
| BigDecimalParser.parse(sb.toString()); | ||
| fail("expected NumberFormatException"); | ||
| } catch (NumberFormatException nfe) { | ||
| assertTrue("exception message starts as expected?", nfe.getMessage().startsWith("Value \"AAAAA")); |
There was a problem hiding this comment.
There is also helper method verifyException in test base class for simple inclusion checks.
(this is fine too)
|
Looks good; I think 1000 is reasonable. |
|
Thank you @pjfanning! Will go in 2.13.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new limit may even be too large