Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #1117: change default recycler pool back to threadLocalPool() for 2.17.1 #1256

Closed
cowtowncoder opened this issue Mar 28, 2024 · 1 comment
Closed

Revert #1117: change default recycler pool back to threadLocalPool() for 2.17.1 #1256

cowtowncoder opened this issue Mar 28, 2024 · 1 comment
Labels
2.17 Issues planned (at earliest) for 2.17
Milestone
2.17.1

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Mar 28, 2024 •
edited

Due to various reported performance issues (even if not all fully evaluated or confirmed), it seems that change #1117 may be too aggressive for 2.x release; or at least 2.17.x.
Since users may reconfigure implementation anyway (and are encouraged to do so explicitly), I think we should revert default back for 2.17.1 and keep it there for 2.17.x.

Based on research (see #1260) plan is to change default impl concurrentDequePool for 2.18(.0), via #1266.
@cowtowncoder cowtowncoder mentioned this issue Mar 28, 2024
Closed
@davseitsev davseitsev mentioned this issue Apr 2, 2024
Closed
@findepi findepi mentioned this issue Apr 2, 2024
Merged
@cowtowncoder cowtowncoder mentioned this issue Apr 14, 2024
Closed
@cowtowncoder
Copy link
Member Author

Supporting this change:

@cowtowncoder cowtowncoder mentioned this issue Apr 15, 2024
Closed
@cowtowncoder cowtowncoder changed the title Revert #1117: change default recycler pool back to threadLocalPool() Revert #1117: change default recycler pool back to threadLocalPool() OR change to concurrentDequePool Apr 17, 2024
@cowtowncoder cowtowncoder changed the title Revert #1117: change default recycler pool back to threadLocalPool() OR change to concurrentDequePool Revert #1117: change default recycler pool back to threadLocalPool() Apr 19, 2024
@cowtowncoder cowtowncoder mentioned this issue Apr 19, 2024
Closed
@cowtowncoder cowtowncoder changed the title Revert #1117: change default recycler pool back to threadLocalPool() Revert #1117: change default recycler pool back to threadLocalPool() for 2.17.1 Apr 19, 2024
cowtowncoder added a commit that referenced this issue Apr 20, 2024
@cowtowncoder
Fix #1256: revert #1117, default recycler pool again `threadLocalPool…
3cce264 
…()` (for 2.17.1+)
cowtowncoder added a commit that referenced this issue Apr 20, 2024
@cowtowncoder
Fix #1256: revert #1117, default recycler pool again `threadLocalPool…
2a4a6dc 
…()` (for 2.17.1+) (#1267)
@cowtowncoder cowtowncoder added the 2.17 Issues planned (at earliest) for 2.17 label Apr 20, 2024
@cowtowncoder cowtowncoder added this to the 2.17.1 milestone Apr 20, 2024
@pjfanning pjfanning mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.17 Issues planned (at earliest) for 2.17
Projects
None yet
Milestone
2.17.1
Development

No branches or pull requests
1 participant
@cowtowncoder