ParameterNamesModule: Conflicting getter definitions when using @JsonProperty annotation which overrides constructor parameter name

[davidboden]

The intention of the example below is that the bean's value is serialised as both ownerUid and accountOwnerUid and that deserialisation uses the ownerUid value. The example can be made to work by removing the ParameterNameModules and relying on the @JsonProperty annotation. It appears to be rather a contrived example (it reflects some real examples, promise); I wanted to report it because I feel that it's fairly clear what the code should do and the behaviour is unexpected.

The error when running the test using Jackson 2.9.9.1 is:
com.fasterxml.jackson.databind.JsonMappingException: Conflicting getter definitions for property "ownerUid": com.example.rest.server.RestServerJacksonModuleTest$TestBeanWithAnnotationsAndDeprecation#getOwnerUid(0 params) vs com.example.rest.server.RestServerJacksonModuleTest$TestBeanWithAnnotationsAndDeprecation#getAccountOwnerUid(0 params)

@Test
void testDeserialisationWorksWithAnnotationsAndDeprecation() throws Exception {
  UUID ownerUid = UUID.randomUUID();
  TestBeanWithAnnotationsAndDeprecation testBeanIn = new TestBeanWithAnnotationsAndDeprecation("endTo", ownerUid);

  StringWriter sw = new StringWriter();
  ObjectMapper objectMapper = new ObjectMapper();
  objectMapper.registerModule(new ParameterNamesModule());
  objectMapper.writeValue(sw, testBeanIn);

  TestBeanWithAnnotationsAndDeprecation testBeanOut = objectMapper.readValue(new StringReader(sw.toString()), TestBeanWithAnnotationsAndDeprecation.class);

  assertThat(testBeanOut.getEndToEndId()).isEqualTo("endTo");
  assertThat(testBeanOut.getAccountOwnerUid()).isEqualTo(ownerUid);
  assertThat(testBeanOut.getOwnerUid()).isEqualTo(ownerUid);
}

static class TestBeanWithAnnotationsAndDeprecation {
  private final String endToEndId;
  private final UUID accountOwnerUid;

  TestBeanWithAnnotationsAndDeprecation(
      @JsonProperty("endToEndId") String endToEndId,
      @JsonProperty("ownerUid") UUID accountOwnerUid
  ) {
    this.endToEndId = endToEndId;
    this.accountOwnerUid = accountOwnerUid;
  }

  public String getEndToEndId() {
    return endToEndId;
  }

  public UUID getAccountOwnerUid() {
    return accountOwnerUid;
  }

  @Deprecated
  public UUID getOwnerUid() {
    return accountOwnerUid;
  }
}

The difference between running the test with the parameter names module is that _renameProperties in POJOPropertiesCollector decides that the property needs to be renamed. The breakpoint in there is not hit without the parameter names module being registered with the ObjectMapper.

[davidboden]

Closing issue here and registering instead as: FasterXML/jackson-modules-java8#123