Avoid root-level wrapping for Map-like types, not just Maps #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick question: what do you mean by "fixed #5"? It looks like this might fix issues with Scala |
My fail test shows these results of serialization to xml: Java:
<xmlSerialize xmlns=""><transitType><key1>1</key1><key2>2</key2></transitType></xmlSerialize>
Javaslang:
<xmlSerialize xmlns=""><transitType><transitType><key1>1</key1><key2>2</key2></transitType></transitType></xmlSerialize>So, I believe here we have the same problem like in #5 |
cowtowncoder
changed the title
|
Ok thanks! I did manual merge via 2.8 branch to get in 2.8.7; same fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom map-like types is still wrapped (see this failed test)