Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing classes error using AGP 8 R8 shrinker #796

Closed
2 of 3 tasks
aroyarexs opened this issue May 2, 2024 · 1 comment
Closed
2 of 3 tasks

Missing classes error using AGP 8 R8 shrinker #796

aroyarexs opened this issue May 2, 2024 · 1 comment
Labels

Comments

@aroyarexs
Copy link

aroyarexs commented May 2, 2024

Search before asking

  • I searched in the issues and found nothing similar.
  • I searched in the issues of databind and other modules used and found nothing similar.
  • I have confirmed that the problem only occurs when using Kotlin.

Describe the bug

We are currently migrating from AGP 7 to 8.
AGP 8 sets android.r8.failOnMissingClasses to true by default.
Therefore we are now getting missing class errors.

Missing class java.beans.ConstructorProperties (referenced from: void com.fasterxml.jackson.databind.ext.Java7SupportImpl.<init>() and 2 other contexts)
Missing class java.beans.Transient (referenced from: void com.fasterxml.jackson.databind.ext.Java7SupportImpl.<init>() and 1 other context)

Using AGP 7 we receive this output as a warning.
Therefore I assume we can add them savely to our proguard-rules.pro file!?

Regards,

Aaron

To Reproduce

Expected behavior

No missing class errors or some hints in the documentation.

Versions

Kotlin: 1.8.21
Jackson-module-kotlin: 2.14.3 and 2.16.2
Jackson-databind: resolved transitively -> 2.14.3 and 2.16.2

Additional context

No response

@aroyarexs aroyarexs added the bug label May 2, 2024
@k163377
Copy link
Contributor

k163377 commented May 4, 2024

This does not appear to be a problem with this repository.
After reading the following article, if there is any missing information, could you please put the issue in that repository?
https://github.com/FasterXML/jackson-docs/wiki/JacksonOnAndroid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants