You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was analyzing the sources and have found some strange things.
LocalTimeDeserializer
YearDeserializer
LocalDateTimeDeserializer
MonthDayDeserializer
OffsetTimeDeserializer
YearMonthDeserializer
classes don't use this as base when ovverriding JSR310DateTimeDeserializerBase#withDateFormate and therefore we can loose leniency and shape. What is the real intention of such code or is it a bug? If this is inteded behaviour, e.g. because implementations don't use leniency and shape and only care about formatter, there is another strange thing why does withShape is ignored by returning this almost everywhere but ignoring 'withLeniency' leads to new deser made?
Without remembering details here I would lean towards it being a simple bug (oversight): whenever creating something using withXxx() it does seem like this ought to be passed.
As to withShape() returning this, that is likely due to that particular deserializer not using shape for changing behavior. Shape is more commonly used with serializers. But it is worth checking for individual deserializers if you have time to do so.
I was analyzing the sources and have found some strange things.
classes don't use this as base when ovverriding
JSR310DateTimeDeserializerBase#withDateFormate
and therefore we can loose leniency and shape. What is the real intention of such code or is it a bug? If this is inteded behaviour, e.g. because implementations don't use leniency and shape and only care about formatter, there is another strange thing why doeswithShape
is ignored by returningthis
almost everywhere but ignoring 'withLeniency' leads to new deser made?LocalTimeDeserializer as an example
The text was updated successfully, but these errors were encountered: