Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only DateTimeFormatter.ISO_OFFSET_DATE_TIME accepted by ZonedDateTimeKeyDeserializer #306

Closed
caluml opened this issue Mar 19, 2024 · 1 comment
Labels
Milestone

Comments

@caluml
Copy link
Contributor

caluml commented Mar 19, 2024

Hello.

Is there any reason for specifying DateTimeFormatter.ISO_OFFSET_DATE_TIME as the format for parsing ZonedDateTimes in ZonedDateTimeKeyDeserializer?

This prevents valid ZonedDateTime keys from being deserialised.

If the second parameter to .parse isn't specified, then all formats supported by .parse are allowed.

I have raised a PR to change this: #305

@cowtowncoder
Copy link
Member

I do not remember if there is any specific reason: I assume whoever added it (could have been me :) ) copied setting from non-key handling.
PR looks good, will add some notes.

@cowtowncoder cowtowncoder changed the title Question and PR about ZonedDateTimeKeyDeserializer Limited formats accepted by ZonedDateTimeKeyDeserializer Mar 23, 2024
@cowtowncoder cowtowncoder changed the title Limited formats accepted by ZonedDateTimeKeyDeserializer Only DateTimeFormatter.ISO_OFFSET_DATE_TIME accepted by ZonedDateTimeKeyDeserializer Mar 23, 2024
@cowtowncoder cowtowncoder modified the milestones: 2.17.0, 2.17.1 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants