Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More powerful display and space selectors #472

Open
rainzm opened this issue Jan 6, 2024 · 2 comments
Open

More powerful display and space selectors #472

rainzm opened this issue Jan 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@rainzm
Copy link

rainzm commented Jan 6, 2024

The initial idea was that I wanted to set a unique bar height for each display.

By reading the documentation, I found that the height belongs to bar properties which is global. I can reach my goal using the methods indicated in this. However, this approach will divide my configuration into two parts, where in actuality, these two configurations only differ in the attribute of "height."

So I wonder if there is a easy way to distinguish bar properties or just height for each display?

Finally, I want to express my gratitude for your creating such a wonderful bar.

@FelixKratz
Copy link
Owner

FelixKratz commented Jan 10, 2024

I had this in mind for some time now and this would be a good oportunity to refactor the bar_manager and bar code.
From the technical point of view this is all very simple, the hard part is to come up with a proper configuration syntax for this.
Obviously, the current configuration syntax should not be affected by this addition so it would need to be a command prefix.

Maybe something like:

sketchybar --bar <property>=<value> ... <property>=<value>

sets properties for the bar globally (as it is now), while

sketchybar --display <positive_integer list> --bar <property>=<value> ... <property>=<value>

would set the properties for the specified displays only.

Problem with this is that it looks as if it is a global display select and should therefore also work for items, e.g.

sketchybar --display <positive_integer list> --set name <property>=<value> ... <property>=<value>

should also only change the item properties on a specific display.

This would require significant modifications to the bar_item logic as well.

And when exposing a --display selector one could go even further and provide a --space selector as well, which should work for both the --bar and --set domains.

I will think about this some more but I like the idea so far. Any further ideas/considerations for this syntax addition?

@FelixKratz FelixKratz added the enhancement New feature or request label Jan 10, 2024
@FelixKratz FelixKratz changed the title Distinct bar properties per display More powerful display and space selectors Jan 10, 2024
@rainzm
Copy link
Author

rainzm commented Jan 10, 2024

This is a top-down, organized structure, which is a brilliant idea. I am eagerly looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants