Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support find's / aggregate's maxTimeMS parameter #1808

Closed
w84thesun opened this issue Jan 16, 2023 · 0 comments · Fixed by #2953
Closed

Support find's / aggregate's maxTimeMS parameter #1808

w84thesun opened this issue Jan 16, 2023 · 0 comments · Fixed by #2953
Assignees
@chilagrow
Labels
area/cursors Issues about cursors code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI
Milestone
v1.6.0

Comments

@w84thesun
Copy link
Contributor

w84thesun commented Jan 16, 2023 •
edited by chilagrow

What should be done?

https://www.mongodb.com/docs/manual/reference/command/getMore/

As we don't support backend-side cursors for now just return from find/aggreagte when timeout is exceeded potentially removing cursor from connInfo.

See also:
https://www.mongodb.com/docs/manual/reference/method/cursor.maxTimeMS/
https://github.com/mongodb/specifications/blob/master/source/client-side-operations-timeout/client-side-operations-timeout.rst#cursors
@w84thesun w84thesun added the code/enhancement Some user-visible feature could work better label Jan 16, 2023
@AlekSi AlekSi assigned AlekSi and w84thesun and unassigned w84thesun Feb 13, 2023
@AlekSi AlekSi removed their assignment Mar 30, 2023
@w84thesun w84thesun mentioned this issue Mar 30, 2023
Merged
9 tasks
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 1, 2023
@AlekSi AlekSi mentioned this issue May 29, 2023
Closed
@AlekSi AlekSi added the area/cursors Issues about cursors label Jun 16, 2023
@chilagrow chilagrow mentioned this issue Jun 21, 2023
Closed
@AlekSi AlekSi changed the title Add support for getMore command's maxTimeMS parameter Support find's / getMore's maxTimeMS parameter Jun 23, 2023
@AlekSi AlekSi changed the title Support find's / getMore's maxTimeMS parameter Support find's / aggregate / getMore's maxTimeMS parameter Jun 29, 2023
@AlekSi AlekSi changed the title Support find's / aggregate / getMore's maxTimeMS parameter Support find's / aggregate's / getMore's maxTimeMS parameter Jun 29, 2023
@chilagrow chilagrow mentioned this issue Jul 3, 2023
Merged
9 tasks
@AlekSi AlekSi added this to the Next milestone Jul 3, 2023
chilagrow added a commit that referenced this issue Jul 10, 2023
@chilagrow
Add MongoDB integration tests for maxTimeMS in find, aggregate …
eb2943e 
…and `getMore` (#2953)

Closes #1808.
@chilagrow chilagrow changed the title Support find's / aggregate's / getMore's maxTimeMS parameter Support find's / aggregate's maxTimeMS parameter Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chilagrow chilagrow

Labels
area/cursors Issues about cursors code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Add integration tests for maxTimeMS in find, aggregate and getMore chilagrow/FerretDB
4 participants
@AlekSi @w84thesun @chilagrow @ferretdb-bot