From c70010073f711291b7136aac39cb4fa7bbf7f243 Mon Sep 17 00:00:00 2001 From: Chi Fujii Date: Tue, 5 Mar 2024 15:00:00 +0900 Subject: [PATCH 1/3] update issue for todo --- internal/handler/msg_createuser.go | 3 +-- internal/handler/msg_usersinfo.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/internal/handler/msg_createuser.go b/internal/handler/msg_createuser.go index d3dfac1eebb6..a9ab8d691ecf 100644 --- a/internal/handler/msg_createuser.go +++ b/internal/handler/msg_createuser.go @@ -46,8 +46,7 @@ func (h *Handler) MsgCreateUser(ctx context.Context, msg *wire.OpMsg) (*wire.OpM return nil, err } - // TODO https://github.com/FerretDB/FerretDB/issues/3777 - // TODO https://github.com/FerretDB/FerretDB/issues/3778 + // TODO https://github.com/FerretDB/FerretDB/issues/4142 if dbName != "$external" && !document.Has("pwd") { return nil, handlererrors.NewCommandErrorMsg( handlererrors.ErrBadValue, diff --git a/internal/handler/msg_usersinfo.go b/internal/handler/msg_usersinfo.go index 774c0f262cc7..fc5624279ff9 100644 --- a/internal/handler/msg_usersinfo.go +++ b/internal/handler/msg_usersinfo.go @@ -45,7 +45,7 @@ func (h *Handler) MsgUsersInfo(ctx context.Context, msg *wire.OpMsg) (*wire.OpMs return nil, lazyerrors.Error(err) } - // TODO https://github.com/FerretDB/FerretDB/issues/3777 + // TODO https://github.com/FerretDB/FerretDB/issues/4141 if err = common.UnimplementedNonDefault(document, "filter", func(v any) bool { if v == nil || v == types.Null { return true From 333216ee79a32acbb2d08049810fb73871198265 Mon Sep 17 00:00:00 2001 From: Chi Fujii Date: Tue, 5 Mar 2024 15:12:59 +0900 Subject: [PATCH 2/3] update user doc too --- website/docs/reference/supported-commands.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/reference/supported-commands.md b/website/docs/reference/supported-commands.md index 40d659de3e81..2659a02a1d75 100644 --- a/website/docs/reference/supported-commands.md +++ b/website/docs/reference/supported-commands.md @@ -209,7 +209,7 @@ Related [issue](https://github.com/FerretDB/FerretDB/issues/78). | | `showCustomData` | ⚠️ | | | | `showPrivileges` | ⚠️ | | | | `showAuthenticationRestrictions` | ⚠️ | | -| | `filter` | ⚠️ | | +| | `filter` | ⚠️ | [Issue](https://github.com/FerretDB/FerretDB/issues/4141) | | | `comment` | ⚠️ | | ### Authentication Commands From 88b12e23e133a899a1ba9da32d7a6d0381b6cc1b Mon Sep 17 00:00:00 2001 From: Chi Fujii Date: Tue, 5 Mar 2024 19:17:43 +0900 Subject: [PATCH 3/3] remove todo --- internal/handler/msg_createuser.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/handler/msg_createuser.go b/internal/handler/msg_createuser.go index a9ab8d691ecf..e02e26bfc738 100644 --- a/internal/handler/msg_createuser.go +++ b/internal/handler/msg_createuser.go @@ -46,7 +46,6 @@ func (h *Handler) MsgCreateUser(ctx context.Context, msg *wire.OpMsg) (*wire.OpM return nil, err } - // TODO https://github.com/FerretDB/FerretDB/issues/4142 if dbName != "$external" && !document.Has("pwd") { return nil, handlererrors.NewCommandErrorMsg( handlererrors.ErrBadValue,