Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array<Token> is assignable to Token #423

Open
cakoose opened this issue Jan 20, 2022 · 0 comments
Open

Array<Token> is assignable to Token #423

cakoose opened this issue Jan 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@cakoose
Copy link
Collaborator

cakoose commented Jan 20, 2022

I sometimes have to use Token to build expressions that Mammoth doesn't currently support. I noticed that Array<Token> is assignable to Token:

import {Token} from '@ff00ff/mammoth/.build/tokens';

const ts = 
function f(ts: Array<Token>): Token {
    return ts; // was expecting a type error here
}

This means TS doesn't catch errors where I accidentally pass Array<Token> where a Token is expected.

Maybe Mammoth should change Token to be nominally typed to avoid this issue?

@cakoose cakoose added the bug Something isn't working label Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant