Option for .as() output to be wrapped in double-quotes?

[echentw]

A use case is if we want to give an expression an alias that includes special characters, e.g.

db.columnName.as('?column?')

Right now, the generated SQL is column_name ?column?, which is invalid SQL. Desired output: column_name "?column?".

Maybe related: #243

If this seems reasonable, I'm happy to work on a PR.
Maybe the usage could look like:

db.columnName.as('?column?', {quoted: true})

[cakoose]

Looks like Mammoth tries to automatically wrap in quotes, but its heuristic is off:

mammoth/workspaces/mammoth/src/naming/index.ts

Lines 4 to 11 in 8122afe

	export const wrapQuotes = (string: string, extended?: boolean) => {
	const isCamelCase = string.match(/[A-Z]/);
	const isReserved = reservedKeywords.has(string) || (extended && allReservedKeywords.has(string));
	const containsSpace = string.includes(` `);
	const shouldWrap = isReserved || isCamelCase || containsSpace;
	return shouldWrap ? `"${string}"` : string;
	};

From the Postgres manual (link):

SQL identifiers and key words must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters in an identifier or key word can be letters, underscores, digits (0-9), or dollar signs ($). Note that dollar signs are not allowed in identifiers according to the letter of the SQL standard, so their use might render applications less portable. The SQL standard will not define a key word that contains digits or starts or ends with an underscore, so identifiers of this form are safe against possible conflict with future extensions of the standard.

So maybe we should replace the isCamelCase check with:

// More restrictive than strictly necessary, so we'll end up quoting some things that don't necessarily need quotes.
const isValidWithoutQuotes = /^[a-z_][A-Za-z0-9_$]*$/;

[cakoose]

Looks like Mammoth tries to automatically wrap in quotes, but its heuristic is off:

mammoth/workspaces/mammoth/src/naming/index.ts

Lines 4 to 11 in 8122afe

	export const wrapQuotes = (string: string, extended?: boolean) => {
	const isCamelCase = string.match(/[A-Z]/);
	const isReserved = reservedKeywords.has(string) || (extended && allReservedKeywords.has(string));
	const containsSpace = string.includes(` `);
	const shouldWrap = isReserved || isCamelCase || containsSpace;
	return shouldWrap ? `"${string}"` : string;
	};

From the Postgres manual (link):

SQL identifiers and key words must begin with a letter (a-z, but also letters with diacritical marks and non-Latin letters) or an underscore (_). Subsequent characters in an identifier or key word can be letters, underscores, digits (0-9), or dollar signs ($). Note that dollar signs are not allowed in identifiers according to the letter of the SQL standard, so their use might render applications less portable. The SQL standard will not define a key word that contains digits or starts or ends with an underscore, so identifiers of this form are safe against possible conflict with future extensions of the standard.

So maybe we should replace the isCamelCase check with:

// More restrictive than strictly necessary, so we'll end up quoting some things that don't necessarily need quotes.
const isValidWithoutQuotes = /^[a-z_][A-Za-z0-9_$]*$/;