Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any use of std::vector #52

Open
truell20 opened this issue May 14, 2016 · 8 comments
Open

Remove any use of std::vector #52

truell20 opened this issue May 14, 2016 · 8 comments

Comments

@truell20
Copy link
Member

truell20 commented May 14, 2016

Switch to C arrays for speed and availability on microcontrollers

@patrickelectric
Copy link
Contributor

It's possible to change std::vector to std::array in the project ? The array template is easier to implement than the vector in embedded systems.

@truell20
Copy link
Member Author

truell20 commented Jun 3, 2016

@patrickelectric It is?

@truell20
Copy link
Member Author

truell20 commented Jun 3, 2016

@patrickelectric Ideally we'd move to c arrays so that Fido could immediately work on AVR

@patrickelectric
Copy link
Contributor

@truell20 and @joshuagruenstein, take a look here.
I compile this vector< vector<double> > input = { {1}, {2}, {5}, {6} }; without problems.

@truell20
Copy link
Member Author

truell20 commented Jun 4, 2016

@patrickelectric Thank you for the link!

@joshuagruenstein
Copy link
Member

@patrickelectric: I still think we should switch to c arrays for a number of reasons.

  1. MCUs have limited flash, and that would take up a lot of room
  2. MCUs have limited processing power, and switching to c arrays would be much faster
  3. Minimal dependencies is a core foundation of our library.

Basically, it seem to me that using a library like that would be a bit of a "hack." I think switching to C arrays, although a larger process right now, will be beneficial for the future of the Fido Library. Of course, that means we need to get around to actually making the switch. @truell20 and I are both somewhat busy this summer, so we'd appreciate help from contributors such as @FlyingGraysons, @Sydriax, and of course you @patrickelectric.

@astroesteban
Copy link

Is the goal of this issue still to switch to C arrays?

@hajikhorasani
Copy link

@joshuagruenstein, Do you still think about moving to C arrays ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants