Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Synology nginx as it doesn't have a name #469

Open
rightsaidfred99 opened this issue Sep 22, 2022 · 4 comments · May be fixed by #494
Open

Doesn't work with Synology nginx as it doesn't have a name #469

rightsaidfred99 opened this issue Sep 22, 2022 · 4 comments · May be fixed by #494

Comments

@rightsaidfred99
Copy link

Environment

  • Operating system (including version): macOS
  • mkcert version (from mkcert -version): 1.4.4
  • Server (where the certificate is loaded): Synology
  • Client (e.g. browser, CLI tool, or script): Synology

What you did

I can import the certificates into Synology's nginx UI. It loads okay

What went wrong

The problem occurs as the certificate generated doesn't have a name. so you can add domains and subdomains with Synology's UI. I propose that it just ads a title/name to the certificate.

@rightsaidfred99
Copy link
Author

Sorry, by title - I mean "Issued To" field which Synology requires.

@android10
Copy link

@rightsaidfred99 I'm interested in this one. Where can you see Synology requirements? Maybe with that in mind we can contribute with a PR here.

elexx added a commit to elexx/mkcert that referenced this issue Jan 16, 2023
@elexx elexx linked a pull request Jan 16, 2023 that will close this issue
@elexx
Copy link

elexx commented Jan 16, 2023

I was not able to find any official certificate requirements by Synology, but I noticed the subject CommonName was not set by mkcert. After setting a CN, Synology accepts the generated certificates. I just pushed an PR to add this.

@elexx
Copy link

elexx commented Jan 16, 2023

This problem seems btw very similar to #47 where iOS would not accept the rootCA if CN was not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants