Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add the missing include header that defines TARGET_OS_OSX #7116

Merged
merged 9 commits into from Oct 20, 2021

Conversation

ChristianEdwardPadilla
Copy link
Contributor

Description

Add the missing include header that defines TARGET_OS_OSX.

Related Issues

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 1, 2021
@ChristianEdwardPadilla ChristianEdwardPadilla changed the title Add the missing include header that defines TARGET_OS_OSX fix(cloud_firestore, auth, core, messaging, remote_config, storage): Add the missing include header that defines TARGET_OS_OSX Oct 1, 2021
@russellwheatley
Copy link
Member

russellwheatley commented Oct 5, 2021

@ChristianEdwardPadilla is this necessary since I believe the target conditionals are already pulled in from the firebase-ios-sdk?

@ChristianEdwardPadilla
Copy link
Contributor Author

@russellwheatley We are seeing issues during cross-compilation. When switching to cross-compiling, the newer version of clang cross compiler introduces the warning flag "-Wundef-prefix=TARGET_OS_". So the import needs to be explicit.

@russellwheatley
Copy link
Member

Hey @ChristianEdwardPadilla, do you mind installing melos and running melos run format in the root of the project, please? This ought to fix the CI failure. Then we can look to get this merged in.

@russellwheatley russellwheatley changed the title fix(cloud_firestore, auth, core, messaging, remote_config, storage): Add the missing include header that defines TARGET_OS_OSX chore: Add the missing include header that defines TARGET_OS_OSX Oct 20, 2021
@russellwheatley russellwheatley merged commit 18fb078 into firebase:master Oct 20, 2021
@firebase firebase locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants